RFR: 8310190: C2 SuperWord: AlignVector is broken, generates misaligned packs [v40]

[Emanuel Peter]

On Fri, 8 Dec 2023 14:55:30 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   remove dead code
>
> src/hotspot/share/opto/vectorization.hpp line 572:
> 
>> 570: 
>> 571: private:
>> 572: #ifdef ASSERT
> 
> Since the `Tracer` class in this file is `NOT_PRODUCT`, I suggest to also go with that here and where the trace methods are used.
> Suggestion:
> 
> #ifndef PRODUCT

Actually, I want to go towards DEBUG/ASSERT only printing, and make the trace flags debug-only (they currently only have effects in debug anyway).
I will refactor this in https://github.com/openjdk/jdk/pull/16620, and for now I will only add ASSERT guarded tracing.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14785#discussion_r1431298284