RFR: 8310190: C2 SuperWord: AlignVector is broken, generates misaligned packs [v49]

Emanuel Peter epeter at openjdk.org
Wed Dec 20 15:13:22 UTC 2023


On Wed, 20 Dec 2023 07:55:30 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   improve comments with fractional / integer question
>
> src/hotspot/share/opto/vectorization.hpp line 663:
> 
>> 661:                                   const int C_pre,
>> 662:                                   const int q,
>> 663:                                   const int r) const;
> 
> I think you can remove `const` from the declaration here in the header file as it only has an effect in the definition in the source file.

I would rather be explicit with everything.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14785#discussion_r1432837848


More information about the hotspot-compiler-dev mailing list