RFR: 8322490: CastNode constructors accepts control node as input [v2]
    Christian Hagedorn 
    chagedorn at openjdk.org
       
    Thu Dec 21 07:12:39 UTC 2023
    
    
  
On Thu, 21 Dec 2023 05:23:11 GMT, Joshua Cao <duke at openjdk.org> wrote:
>> It is a common pattern to have:
>> 
>> 
>> Node* n = new CastNode(...);
>> n->set_req(control_node);
>> 
>> 
>> We can modify the constructor to set the control node. It makes the code a little tidier.
>> 
>> Passes tier1 locally on my Linux machine
>
> Joshua Cao has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Convert some CastIINode instantiations to use the constructor with ctrl
>   node
Otherwise, the cleanup looks good.
-------------
Marked as reviewed by chagedorn (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/17162#pullrequestreview-1792341125
    
    
More information about the hotspot-compiler-dev
mailing list