RFR: 8310190: C2 SuperWord: AlignVector is broken, generates misaligned packs [v43]

Emanuel Peter epeter at openjdk.org
Thu Dec 21 15:43:07 UTC 2023


On Fri, 15 Dec 2023 10:46:53 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   renamings and proof improvement in adjust_pre_loop_limit_to_align_main_loop_vectors
>
> Thanks for addressing my other comments! I really like the new structure of having an `AlignmentSolution` interface with different alignment solution classes. I have some more comments but mostly fine tuning - it's already in a quite good shape and the comments really add a lot of benefit to understand the idea behind the code. We get there :-)

@chhagedorn thank you very much for the detailed review!
I think now we are at a point that is stable enough, so reviewers can jump in ;)
@fg1417 @vnkozlov @TobiHartmann

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14785#issuecomment-1866513361


More information about the hotspot-compiler-dev mailing list