RFR: 8322490: cleanup CastNode construction [v4]
Joshua Cao
duke at openjdk.org
Fri Dec 22 00:46:04 UTC 2023
> It is a common pattern to have:
>
>
> Node* n = new CastNode(...);
> n->set_req(control_node);
>
>
> We can modify the constructor to set the control node. It makes the code a little tidier.
>
> Passes tier1 locally on my Linux machine
Joshua Cao has updated the pull request incrementally with one additional commit since the last revision:
Cleanup make_cast functions
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/17162/files
- new: https://git.openjdk.org/jdk/pull/17162/files/69c796b6..574617ef
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=17162&range=03
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=17162&range=02-03
Stats: 59 lines in 5 files changed: 7 ins; 31 del; 21 mod
Patch: https://git.openjdk.org/jdk/pull/17162.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/17162/head:pull/17162
PR: https://git.openjdk.org/jdk/pull/17162
More information about the hotspot-compiler-dev
mailing list