RFR: 8305638: Refactor Template Assertion Predicate Bool creation and Predicate code in Split If and Loop Unswitching

Fri Dec 22 15:48:12 UTC 2023

On Fri, 22 Dec 2023 13:34:15 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Also: why can the invariant if not be eliminated in the loops as a dominating if, with and independent optimization? Would that not be cleaner? Well I guess maybe we just want to be sure that it happens.
>
> Yeah, the naming of "old / new", "true / false", "fast / slow" is confusing and redundant. Would be nice if you said which are the same. Or maybe remove some of these names entirely.
> I suggest: Old -> True, New -> False.

`create_slow_version_of_loop` should probably be renamed as well.
Maybe `clone_loop_and_create_loop_selector`?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16877#discussion_r1435079338