RFR: 8310190: C2 SuperWord: AlignVector is broken, generates misaligned packs [v57]
Emanuel Peter
epeter at openjdk.org
Fri Dec 22 15:52:03 UTC 2023
On Fri, 22 Dec 2023 15:40:47 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:
>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Apply suggestions from code review by Christian
>>
>> Co-authored-by: Christian Hagedorn <christian.hagedorn at oracle.com>
>
> Thanks a lot Emanuel for all the discussions and for addressing all my comments online and offline :-)
>
> It looks very good now and it's easy to follow the logic. The proofs are great and really helpful to better understand the (rather simple in the end) code for proving and calculating the alignment solutions. Thanks for putting the extra effort in here.
>
> I will have another complete look at the entire PR in the new year. But I think it looks good!
Thank you very much @chhagedorn for the very extensive review process here 😊
-------------
PR Comment: https://git.openjdk.org/jdk/pull/14785#issuecomment-1867833613
More information about the hotspot-compiler-dev
mailing list