RFR: 8322490: cleanup CastNode construction [v5]

Paul Hohensee phh at openjdk.org
Fri Dec 22 19:20:48 UTC 2023


On Fri, 22 Dec 2023 19:09:59 GMT, Joshua Cao <duke at openjdk.org> wrote:

>> It is a common pattern to have:
>> 
>> 
>> Node* n = new CastNode(...);
>> n->set_req(control_node);
>> 
>> 
>> We can modify the constructor to set the control node. It makes the code a little tidier.
>> 
>> Passes tier1 locally on my Linux machine
>
> Joshua Cao has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix asterisk formatting

Marked as reviewed by phh (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/17162#pullrequestreview-1794901822


More information about the hotspot-compiler-dev mailing list