RFR: 8322294: Cleanup NativePostCallNop [v2]

[Richard Reingruber]

On Fri, 22 Dec 2023 11:10:07 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> Richard Reingruber has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review Martin
>
> src/hotspot/cpu/s390/nativeInst_s390.hpp line 661:
> 
>> 659:   bool check() const { Unimplemented(); return false; }
>> 660:   bool decode(int32_t& oopmap_slot, int32_t& cb_offset) const { return false; }
>> 661:   bool patch(int32_t oopmap_slot, int32_t cb_offset) { Unimplemented() ; return false; }
> 
> Whitespace between `()` and `;`.

Done. I also reverted the change of `make_deopt`.

> src/hotspot/share/runtime/frame.inline.hpp line 109:
> 
>> 107: inline const ImmutableOopMap* frame::get_oop_map() const {
>> 108:   if (_cb == nullptr) return nullptr;
>> 109:   if (_cb->oop_maps() != nullptr) {
> 
> Could be shorter: `if (_cb == nullptr || _cb->oop_maps() == nullptr) return nullptr;`

Yes, that's better.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17150#discussion_r1435525912
PR Review Comment: https://git.openjdk.org/jdk/pull/17150#discussion_r1435525925