RFR: 8282365: Consolidate and improve division by constant idealizations [v35]

[Quan Anh Mai]

On Mon, 18 Dec 2023 17:07:32 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> I see there are multiple cases where a header is defined in multiple source files, and these are used exclusively for `DivNode`s so putting them here seems logical.
>
> If it were true these are only used in divnode.cpp then the declarations could
> be in that file. But these are also used in the gtest. That gtest duplicates
> the declaration. Better would be for it to include the suggested
> divconstants.hpp.
> 
> Having examples of an unusual style doesn't mean we want more, at least not
> without some fairly good reason.

I see, I moved it to another file then.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/9947#discussion_r1435742851