RFR: 8298952: All nodes should have type(n) == Value(n) after IGVN [v5]

Emanuel Peter epeter at openjdk.org
Thu Feb 2 07:09:32 UTC 2023


On Wed, 1 Feb 2023 07:53:20 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   two small fixes and copyright 2023
>
> src/hotspot/share/opto/phaseX.cpp line 1670:
> 
>> 1668:                 add_users_to_worklist0(region0);
>> 1669:             }
>> 1670:           }
> 
> Just a general comment: The method has become quite long. I guess we could break it up into smaller methods at some point - but that might better be done when unifying the CCP and IGVN notification code.

Yes, I am planning to do this refactoring in an upcoming RFE [JDK-8298094](https://bugs.openjdk.org/browse/JDK-8298094)

-------------

PR: https://git.openjdk.org/jdk/pull/11775


More information about the hotspot-compiler-dev mailing list