RFR: 8299155: C2: SubTypeCheckNode::verify() should not produce dependencies / oop pool entries [v2]

Roland Westrelin roland at openjdk.org
Thu Feb 2 15:53:00 UTC 2023


On Thu, 2 Feb 2023 14:13:34 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> Roland Westrelin has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review
>
> src/hotspot/share/opto/subtypenode.cpp line 206:
> 
>> 204: }
>> 205: 
>> 206: Node* SubTypeCheckNode::load_klass(PhaseGVN* phase, Node* obj_or_subklass) const {
> 
> I think this should either be a static method or the `obj_or_subklass` argument should be removed and replaced by `in(ObjOrSubKlass)` in the method body.

Good suggestion. I made that change. Thanks for reviewing.

-------------

PR: https://git.openjdk.org/jdk/pull/12383


More information about the hotspot-compiler-dev mailing list