RFR: 8301838: PPC: continuation yield intrinsic: exception check not needed if yield succeeded

Lutz Schmidt lucy at openjdk.org
Wed Feb 8 08:51:45 UTC 2023


On Tue, 7 Feb 2023 09:03:39 GMT, Richard Reingruber <rrich at openjdk.org> wrote:

> This small enhancement let's the continuation yield intrinsic return if the yield succeeded.
> Doing so is ok because there will never be a pending exception if the yield succeeded.
> 
> All continuation tests succeeded.
> 
> GHA: some cross compiles failed because packages could not be downloaded. I tried to restart these but that didn't work.

Changes requested by lucy (Reviewer).

src/hotspot/cpu/ppc/sharedRuntime_ppc.cpp line 1998:

> 1996:   __ mtlr(R0);
> 1997:   __ blr();
> 1998: 

This newly introduced code is an exact duplicate from below. I would prefer code reuse by treating the "L_pinned" part as "out-of-line". Instead of branching over forward_exception_entry, you could branch back to the return code. If you do so, the pop&return code below becomes obsolete.

-------------

PR: https://git.openjdk.org/jdk/pull/12450


More information about the hotspot-compiler-dev mailing list