RFR: 8301838: PPC: continuation yield intrinsic: exception check not needed if yield succeeded [v2]
Richard Reingruber
rrich at openjdk.org
Wed Feb 8 09:21:25 UTC 2023
On Wed, 8 Feb 2023 09:17:07 GMT, Richard Reingruber <rrich at openjdk.org> wrote:
>> This small enhancement let's the continuation yield intrinsic return if the yield succeeded.
>> Doing so is ok because there will never be a pending exception if the yield succeeded.
>>
>> All continuation tests succeeded.
>>
>> GHA: some cross compiles failed because packages could not be downloaded. I tried to restart these but that didn't work.
>
> Richard Reingruber has updated the pull request incrementally with two additional commits since the last revision:
>
> - freeze(JavaThread* current, intptr_t* sp) returns int, so use 32bit compare
> - Remove duplicated return sequence as Lutz suggested
src/hotspot/cpu/ppc/sharedRuntime_ppc.cpp line 1983:
> 1981: Label L_pinned;
> 1982:
> 1983: __ cmpwi(CCR0, R3_RET, 0);
Since I'm at it: the call above returns `int` so it is better to use a 32bit compare.
-------------
PR: https://git.openjdk.org/jdk/pull/12450
More information about the hotspot-compiler-dev
mailing list