RFR: 8298935: fix cyclic dependency bug in create_pack logic in SuperWord::find_adjacent_refs

Richard Reingruber rrich at openjdk.org
Thu Feb 9 09:13:45 UTC 2023


On Thu, 9 Feb 2023 08:53:19 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

> @tstuefe @reinrich Would you mind reviewing / testing testing this for PPC? Maybe you would also want to port some tests to PPC?

Thanks for pinging. I'll do the testing. I guess I cannot do the review though because I'm not working in that area. Maybe @TheRealMDoerr want's to have a look?

> 
> I also wonder: Would it be possible to have some verification added to the `SuperWord` code before scheduling, that verifies that all packs are memory aligned, if `vectors_should_be_aligned == false` ? Because currently I can do `-XX:+AlignVector`, but if we make a mistake and still emit unaligned vector load/stores we would not detect this on an intel machine for example.

Sorry cannot answer that.
(I mean without digging a week in the code).

Thanks, Richard.

-------------

PR: https://git.openjdk.org/jdk/pull/12350


More information about the hotspot-compiler-dev mailing list