Integrated: 8302066: Counter _number_of_nmethods_with_dependencies should be atomic.

Robbin Ehn rehn at openjdk.org
Thu Feb 9 18:42:55 UTC 2023


On Wed, 8 Feb 2023 11:48:13 GMT, Robbin Ehn <rehn at openjdk.org> wrote:

> Hi, please consider!
> 
> We increment this counter when holding CodeCache, but loads are holding Compile_lock.
> Lets just make it atomic so we don't need to reason about if there is some race here.
> Also we are trying to avoid 'dirty' reads in the code base. (since in theory it is subject to things like word-tearing)
> 
> Testing tier1 in progress.
> 
> Thanks, Robbin

This pull request has now been integrated.

Changeset: 77ead449
Author:    Robbin Ehn <rehn at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/77ead449e494f4dae147144dbcc978bb107e2817
Stats:     13 lines in 2 files changed: 2 ins; 0 del; 11 mod

8302066: Counter _number_of_nmethods_with_dependencies should be atomic.

Reviewed-by: thartmann, kvn

-------------

PR: https://git.openjdk.org/jdk/pull/12470


More information about the hotspot-compiler-dev mailing list