RFR: 8302172: [JVMCI] HotSpotResolvedJavaMethodImpl.canBeInlined must respect @ForceInline

Dean Long dlong at openjdk.org
Fri Feb 10 00:27:51 UTC 2023


On Thu, 9 Feb 2023 20:32:12 GMT, Doug Simon <dnsimon at openjdk.org> wrote:

> The implementation of `HotSpotResolvedJavaMethodImpl.canBeInlined` must return true for a method annotated with `@ForceInline`.

Changes requested by dlong (Reviewer).

src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotResolvedJavaMethodImpl.java line 582:

> 580:         if (isForceInline()) {
> 581:             return true;
> 582:         }

Should this use shouldBeInlined() instead?  Would it make sense for shouldBeInlined() to return true but canBeInlined() returns false?

-------------

PR: https://git.openjdk.org/jdk/pull/12501


More information about the hotspot-compiler-dev mailing list