RFR: 8302147: Speed up compiler/jvmci/compilerToVM/IterateFramesNative.java [v3]

Vladimir Kozlov kvn at openjdk.org
Sat Feb 11 00:31:29 UTC 2023


On Fri, 10 Feb 2023 16:21:09 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> We have two run statements.
>> 
>> The `-Xbatch`  version takes `5 sec`, now `1.5`.
>> And the `-Xcomp`  took `19` and now takes `0.5`.
>> 
>> I discussed it with @woess the original author of the test. He suggested this fix.
>> The first run statement still works as before, the second one, which sets `-Dcompiler.jvmci.compilerToVM.IterateFramesNative.checkCompiled=true` and has `CHECK_COMPILED == true` now only runs one iteration. This should be sufficient, we see that the whitebox checks successfully that the methods were compiled.
>> 
>> **Update**
>> For `-Xbatch`, I simply reduced the iteration count. I saw that after `255` iterations both methods were already compiled, so I thought `1000` should suffice. I moved the compilation-verification outside the loop - so now we check that we compile in both cases.
>> 
>> Well, it actually seems to fail testing in some cases. Seems `1000` iterations is not enough.
>
> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
> 
>   alternative that looks a bit better

Okay.

-------------

Marked as reviewed by kvn (Reviewer).

PR: https://git.openjdk.org/jdk/pull/12496


More information about the hotspot-compiler-dev mailing list