RFR: JDK-8297031: IGV: Copy extracted nodes and layout for cloned graph [v2]
Tobias Holenstein
tholenstein at openjdk.org
Mon Feb 13 14:48:53 UTC 2023
> previously in IGV the user could open a graph in a new tab by right clicking on a graph -> "open clone". Unfortunately, this did not open a "real" clone if the graph was already opened in another tab: Neither the extracted nodes nor the chosen layout (sea, block, cfg) were applied to the new tab.
>
> # Solution
> 1. "open clone" was renamed to "Open in new tab"
> <img width="1246" alt="new_tab" src="https://user-images.githubusercontent.com/71546117/218485025-dd6c3ca1-59a0-43b2-ace0-f2f054f68a6c.png">
>
>
> 2. The user can right click a Tab -> "Clone" . This opens a proper clone with the same extracted nodes and the chosen layout
> <img width="1036" alt="clone" src="https://user-images.githubusercontent.com/71546117/218485079-c92ab3e0-1daa-49a9-bc08-beeac82a69ba.png">
Tobias Holenstein has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
- clone button states as well
- cloning
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/12534/files
- new: https://git.openjdk.org/jdk/pull/12534/files/0276b4dc..12ca33dc
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=12534&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=12534&range=00-01
Stats: 160417 lines in 3726 files changed: 82817 ins; 50649 del; 26951 mod
Patch: https://git.openjdk.org/jdk/pull/12534.diff
Fetch: git fetch https://git.openjdk.org/jdk pull/12534/head:pull/12534
PR: https://git.openjdk.org/jdk/pull/12534
More information about the hotspot-compiler-dev
mailing list