RFR: JDK-8297031: IGV: Copy extracted nodes and layout for cloned graph [v3]
Roberto Castañeda Lozano
rcastanedalo at openjdk.org
Mon Feb 13 15:07:29 UTC 2023
On Mon, 13 Feb 2023 14:54:57 GMT, Tobias Holenstein <tholenstein at openjdk.org> wrote:
>> previously in IGV the user could open a graph in a new tab by right clicking on a graph -> "open clone". Unfortunately, this did not open a "real" clone if the graph was already opened in another tab: Neither the extracted nodes nor the chosen layout (sea, block, cfg) were applied to the new tab.
>>
>> # Solution
>> 1. "open clone" was renamed to "Open in new tab"
>> <img width="1246" alt="new_tab" src="https://user-images.githubusercontent.com/71546117/218485025-dd6c3ca1-59a0-43b2-ace0-f2f054f68a6c.png">
>>
>>
>> 2. The user can right click a Tab -> "Clone" . This opens a proper clone with the same extracted nodes and the chosen layout
>> <img width="1036" alt="clone" src="https://user-images.githubusercontent.com/71546117/218485079-c92ab3e0-1daa-49a9-bc08-beeac82a69ba.png">
>
> Tobias Holenstein has updated the pull request incrementally with one additional commit since the last revision:
>
> copyright year
Thanks for fixing this, Toby! I tried it out and works as expected. Just a suggestion: if it is not too difficult to implement, it would be a nice usability improvement to disable `Open in new tab` when `Open` would already open the graph in a new tab (i.e. when no graph in the same group is opened).
-------------
Marked as reviewed by rcastanedalo (Reviewer).
PR: https://git.openjdk.org/jdk/pull/12534
More information about the hotspot-compiler-dev
mailing list