RFR: JDK-8297031: IGV: Copy extracted nodes and layout for cloned graph [v4]

Tobias Holenstein tholenstein at openjdk.org
Mon Feb 13 16:20:17 UTC 2023


> previously in IGV the user could open a graph in a new tab by right clicking on a graph -> "open clone". Unfortunately, this did not open a "real" clone if the graph was already opened in another tab: Neither the extracted nodes nor the chosen layout (sea, block, cfg) were applied to the new tab.
> 
> # Solution
> 1. "open clone" was renamed to "Open in new tab"
> <img width="1246" alt="new_tab" src="https://user-images.githubusercontent.com/71546117/218485025-dd6c3ca1-59a0-43b2-ace0-f2f054f68a6c.png">
> 
> 
> 2. The user can right click a Tab -> "Clone" . This opens a proper clone with the same extracted nodes and the chosen layout
> <img width="1036" alt="clone" src="https://user-images.githubusercontent.com/71546117/218485079-c92ab3e0-1daa-49a9-bc08-beeac82a69ba.png">

Tobias Holenstein has updated the pull request incrementally with one additional commit since the last revision:

  Renaming and disable NewGraphTabAction when no tab opened

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/12534/files
  - new: https://git.openjdk.org/jdk/pull/12534/files/fa1ff117..b7521528

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=12534&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=12534&range=02-03

  Stats: 274 lines in 7 files changed: 137 ins; 132 del; 5 mod
  Patch: https://git.openjdk.org/jdk/pull/12534.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/12534/head:pull/12534

PR: https://git.openjdk.org/jdk/pull/12534


More information about the hotspot-compiler-dev mailing list