RFR: 8299546: C2: MulLNode::mul_ring() wrongly returns bottom type due to casting errors with large numbers [v3]

Tue Feb 14 02:03:43 UTC 2023

On Mon, 13 Feb 2023 19:16:31 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Yes, I've seen that - was just not too sure about using it as the C++ standard leaves it up to the compiler to decide (most compilers will probably just sign extend). However, I see that we have already been using `java_shift_right`. So it might be fine to just use that as well.
>
> What are your thoughts about that @vnkozlov?

We need @kbarrett opinion on C++ code for this case.
I prefer to use already defined functions if they work to avoid duplication.

-------------

PR: https://git.openjdk.org/jdk/pull/11907