RFR: 8302147: Speed up compiler/jvmci/compilerToVM/IterateFramesNative.java [v4]

Tobias Hartmann thartmann at openjdk.org
Tue Feb 14 07:45:47 UTC 2023


On Mon, 13 Feb 2023 14:34:00 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> We have two run statements.
>> 
>> The `-Xbatch`  version takes `5 sec`, now `1.5-2.3`.
>> And the `-Xcomp`  took `19` and now takes `0.5`.
>> 
>> I discussed it with @woess the original author of the test. He suggested this fix.
>> The first run statement still works as before, the second one, which sets `-Dcompiler.jvmci.compilerToVM.IterateFramesNative.checkCompiled=true` and has `CHECK_COMPILED == true` now only runs one iteration. This should be sufficient, we see that the whitebox checks successfully that the methods were compiled.
>> 
>> **Update**
>> For `-Xbatch`, I simply reduced the iteration count. We had `CompilerWhiteBoxTest.THRESHOLD = 150_000` iterations, now I reduced it to `10_000`, which should be sufficient.
>> 
>> I would have liked to assert compilation in both cases, but the `-Xbatch` case does not always lead to compilation, especially when we have `-XX:-TieredCompilation`.
>
> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix it for -XX:-TieredCompilation

Looks good to me.

-------------

Marked as reviewed by thartmann (Reviewer).

PR: https://git.openjdk.org/jdk/pull/12496


More information about the hotspot-compiler-dev mailing list