RFR: 8302369: Reduce the stack size of the C1 compiler
SUN Guoyun
duke at openjdk.org
Wed Feb 15 09:37:44 UTC 2023
On Tue, 14 Feb 2023 03:45:04 GMT, SUN Guoyun <duke at openjdk.org> wrote:
> The current fact is that C1 uses more stack space than the C2 compiler, taking method `java.lang.Object::<init>`as an example on the x86_64 platform , the stack size used is 48 bytes for C1 compiler, while only 16 bytes is used for C2 compiler.
>
> ========== C1-compiled nmethod =====
> 0x00007f93311cc747: push %rbp
> 0x00007f93311cc748: sub $0x30,%rsp // stack sizes is 48 bytes
>
>
> ========== C2-compiled nmethod =======
> pushq rbp # Save rbp
> subq rsp, #16 # Create frame //stack sizes is 16 bytes
>
> After this patch, the C1 compiler will use less stack space. also taking method `java.lang.Object::<init>`as an example on the x86_64 platform , the stack size used is 16 bytes, which is the same as C2 compiler.
>
> ========== C1-compiled nmethod =====
> 0x00007f80491ce647: push %rbp
> 0x00007f80491ce648: sub $0x10,%rsp //stack sizes is 16 bytes
> In order to reduce the minimum size lower than 2, C1 would need to determine (in advance?) if any stubs might be called. Maybe there is a way to calculate actual frame size required based on actual stores emitted, but that seems tricky if the prologue has already been emitted.
I had do a simple verification locally to confirm `stubs be called` happened before `prologue be emitted`, so this scheme is feasible. Thank @dean-long for your suggestion, I will make more detailed changes, test and submit new patch later.
-------------
PR: https://git.openjdk.org/jdk/pull/12548
More information about the hotspot-compiler-dev
mailing list