RFR: JDK-8302595: use-after-free related to GraphKit::clone_map [v2]

[Justin King]

On Wed, 15 Feb 2023 19:33:10 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Justin King has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update based on review
>>   
>>   Signed-off-by: Justin King <jcking at google.com>
>
> src/hotspot/share/opto/compile.hpp line 940:
> 
>> 938:   Unique_Node_List* for_igvn()                  { return _for_igvn; }
>> 939:   inline void       record_for_igvn(Node* n);   // Body is after class Unique_Node_List.
>> 940:   inline void       remove_for_igvn(Node* n);   // Body is after class Unique_Node_List.
> 
> May be change comment.

Updated to say its in node.hpp. Though it is technically still after Unique_Node_List.

> src/hotspot/share/opto/graphKit.cpp line 743:
> 
>> 741: // to destruct/free/delete in the exact opposite order as clone_map().
>> 742: void GraphKit::destruct_map_clone(SafePointNode* m) {
>> 743:   if (m == nullptr) return;
> 
> Please rename `m` to `sfp`. `m` is for `memory`.

Done. Was just following clone_map.

-------------

PR: https://git.openjdk.org/jdk/pull/12578