RFR: 8295979: [IR Framework] Improve IR matching warning
Emanuel Peter
epeter at openjdk.org
Thu Feb 16 14:11:16 UTC 2023
The IR framework already warns that some rule was not applied. But it was not clear which ones were not applied.
I now say which one was not applied (eg `2 of 3`). I improved the wording, it was not always correct. And I also print the constraints, so that one can more quickly understand why it was not applied.
Given the numbers `x of N` one can easily deduce if there are still rules that were applied.
Examples:
[IREncodingPrinter] Disabling IR matching for rule 1 of 3 in testReductionAndLong: None of the flag constraints met (applyIfOr): SuperWordReductions, false, LoopMaxUnroll, <= 4
[IREncodingPrinter] Disabling IR matching for rule 3 of 3 in testReductionAndLong: Not all feature constraints are met (applyIfCPUFeatureAnd): sse4.1, true, avx2, false
[IREncodingPrinter] Disabling IR matching for rule 1 of 3 in testReductionOrLong: None of the flag constraints met (applyIfOr): SuperWordReductions, false, LoopMaxUnroll, <= 4
[IREncodingPrinter] Disabling IR matching for rule 3 of 3 in testReductionOrLong: Not all feature constraints are met (applyIfCPUFeatureAnd): sse4.1, true, avx2, false
[IREncodingPrinter] Disabling IR matching for rule 1 of 3 in testReductionMulLong: None of the flag constraints met (applyIfOr): SuperWordReductions, false, LoopMaxUnroll, <= 4
[IREncodingPrinter] Disabling IR matching for rule 2 of 3 in testReductionMulLong: None of the feature constraints met (applyIfCPUFeatureOr): avx512dq, true, sve, true
[IREncodingPrinter] Disabling IR matching for rule 3 of 3 in testReductionMulLong: Not all feature constraints are met (applyIfCPUFeatureAnd): sse4.1, true, avx2, false
-------------
Commit messages:
- 8295979: [IR Framework] Improve IR matching warning
Changes: https://git.openjdk.org/jdk/pull/12589/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=12589&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8295979
Stats: 12 lines in 1 file changed: 1 ins; 0 del; 11 mod
Patch: https://git.openjdk.org/jdk/pull/12589.diff
Fetch: git fetch https://git.openjdk.org/jdk pull/12589/head:pull/12589
PR: https://git.openjdk.org/jdk/pull/12589
More information about the hotspot-compiler-dev
mailing list