RFR: 8302681: [IR Framework] Only allow cpuFeatures from a verified list [v3]

Vladimir Kozlov kvn at openjdk.org
Wed Feb 22 19:10:38 UTC 2023


On Tue, 21 Feb 2023 12:24:39 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - add comment
>>  - modified test that used non-existent cpu feature
>
> test/hotspot/jtreg/compiler/lib/ir_framework/test/IREncodingPrinter.java line 247:
> 
>> 245:             // General
>> 246:             "sha3",
>> 247:             "fma",
> 
> I would put this under `x86` or something.

Please add

// Consult `CPU_FEATURE_FLAGS` in corresponding vm_version_<cpu>.hpp file to find correct cpu feature's name.

-------------

PR: https://git.openjdk.org/jdk/pull/12669


More information about the hotspot-compiler-dev mailing list