RFR: 8303089: [jittester] Add time limit to IRTree generation
Evgeny Nikitin
enikitin at openjdk.org
Thu Feb 23 19:37:09 UTC 2023
On Thu, 23 Feb 2023 01:46:05 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:
>> Sometimes, the generation could take more than an hour and probably never stop. This PR adds a time limit (defaults to 10 minutes) to the generation of a single test.
>
> test/hotspot/jtreg/testlibrary/jittester/src/jdk/test/lib/jittester/Automatic.java line 143:
>
>> 141: if (generatorThread.isAlive()) {
>> 142: // maxTime reached, so, proceed to next test generation
>> 143: generatorThread.interrupt();
>
> I quickly looked at the code and I didn't find any places where the interrupted flag is checked. Does it stop the thread?
I didn't changed that code, and it is kind of misleading, yes. The limit I added concerns L124, the `generateIRTree` call. On the contrary, the InterruptedException you're looking for is captured in the `TestsGenerator`, methods `generateGoldenOut` and `compilePrinter` as well as in the `JavaCodeGenerator.compileJavaFile`.
-------------
PR: https://git.openjdk.org/jdk/pull/12722
More information about the hotspot-compiler-dev
mailing list