RFR: 8302267: [jittester] Improve separation of test generation and execution [v2]

[Andrey Turbanov]

On Wed, 22 Feb 2023 17:43:23 GMT, Evgeny Nikitin <enikitin at openjdk.org> wrote:

>> Please review a set of improvements that should improve working with other fuzzing generators and usage of JitTesterDriver with tests generated not by the JITTester:
>> 
>> - Provide better separation of individual test generation from java file writing, compiling, executing, etc.;
>> - Introduce distinct Phases of the generation process (Generation, Compilation, GoldRun and VerificationRun);
>> - Extract JItTesterDriver headers generation so that it would be possible to provide other header generators;
>> - Introduce error tolerance to not get distracted by OOMEs, intrinsics missing in the compiled code, etc.;
>> - Make it possible to specify time limit for an individual test generation;
>> - Give better control over temp/workdir creation and cleaning;
>> - Unify external process running;
>> - Introduce UTF-8 support in external processes' output and human-readable escaping of it;
>
> Evgeny Nikitin has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Ignore large files

test/hotspot/jtreg/testlibrary/jittester/src/jdk/test/lib/jittester/HeaderFormatter.java line 38:

> 36: 
> 37:     public static class Builder {
> 38:         private Function<String, String[]>  preRunActions = s -> new String[0];

Suggestion:

        private Function<String, String[]> preRunActions = s -> new String[0];

test/hotspot/jtreg/testlibrary/jittester/src/jdk/test/lib/jittester/HeaderFormatter.java line 78:

> 76:     }
> 77: 
> 78:     public  String getJtregHeader(String mainClassName) {

Suggestion:

    public String getJtregHeader(String mainClassName) {

test/hotspot/jtreg/testlibrary/jittester/src/jdk/test/lib/jittester/ProcessRunner.java line 59:

> 57: 
> 58:         src.chars().forEachOrdered(code -> {
> 59:             if  ((code >= 32) && (code <= 126) && (code != 92) || (code == 9)) {

Suggestion:

            if ((code >= 32) && (code <= 126) && (code != 92) || (code == 9)) {

-------------

PR: https://git.openjdk.org/jdk/pull/12527