RFR: 8302830: AArch64: Fix the mismatch between cas.m4 and aarch64.ad

Hao Sun haosun at openjdk.org
Mon Feb 27 02:17:02 UTC 2023


On Mon, 20 Feb 2023 12:57:46 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> Fix the following mismatch between cas.m4 and aarch64.ad.
>> 
>> 
>> $ m4 cas.m4 > cas.gen.ad
>> $ sed  '8930,9404!d' aarch64.ad > res.ad
>> $ diff -uN cas.gen.ad res.ad | cat -A
>> 
>> --- cas.gen.ad^I2023-02-20 04:18:46.624289978 +0000$
>> +++ res.ad^I2023-02-20 04:19:08.780351888 +0000$
>> @@ -15,7 +15,7 @@$
>>  // This pattern is generated automatically from cas.m4.$
>>  // DO NOT EDIT ANYTHING IN THIS SECTION OF THE FILE$
>>  instruct compareAndExchangeB(iRegINoSp res, indirect mem, iRegI oldval, iRegI newval, rFlagsReg cr) %{$
>> -  $
>> +$
>>    match(Set res (CompareAndExchangeB mem (Binary oldval newval)));$
>>    ins_cost(2 * VOLATILE_REF_COST);$
>>    effect(TEMP_DEF res, KILL cr);$
>> ...
>> 
>> 
>> Besides, update the comment since "aarch_ad_cas.m4" was renamed to "cas.m4".
>
> Whitespace is all messed up. try this:
> 
> [foo.zip](https://github.com/openjdk/jdk/files/10784530/foo.zip)

@theRealAph  Could you help take another look at this PR? Thanks in advance.

-------------

PR: https://git.openjdk.org/jdk/pull/12647


More information about the hotspot-compiler-dev mailing list