RFR: JDK-8301074: Replace NULL with nullptr in share/opto/

Johan Sjölen jsjolen at openjdk.org
Mon Feb 27 10:46:43 UTC 2023


On Wed, 22 Feb 2023 23:03:48 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Hi, this PR changes all occurrences of NULL to nullptr for the subdirectory share/opto/. Unfortunately the script that does the change isn't perfect, and so we
>> need to comb through these manually to make sure nothing has gone wrong. I also review these changes but things slip past my eyes sometimes.
>> 
>> Here are some typical things to look out for:
>> 
>>     No changes but copyright header changed (probably because I reverted some changes but forgot the copyright).
>>     Macros having their NULL changed to nullptr, these are added to the script when I find them. They should be NULL.
>>     nullptr in comments and logs. We try to use lower case "null" in these cases as it reads better. An exception is made when code expressions are in a comment.
>> 
>> An example of this:
>> 
>> 
>> // This function returns null
>> void* ret_null();
>> // This function returns true if *x == nullptr
>> bool is_nullptr(void** x);
>> 
>> 
>> Note how nullptr participates in a code expression here, we really are talking about the specific value nullptr.
>> 
>> Thanks!
>
> src/hotspot/share/opto/connode.hpp line 81:
> 
>> 79:       return new ConPNode( TypePtr::NULL_PTR ) ;
>> 80:     else
>> 81:       return new ConPNode( TypeRawPtr::make(con) );
> 
> Please also add `{}` for this ` if else` since you are changing this code. Code style.

Also removed the extra spaces in function calls.

-------------

PR: https://git.openjdk.org/jdk/pull/12187


More information about the hotspot-compiler-dev mailing list