RFR: JDK-8302040: Port fdlibm sqrt to Java [v5]
Tobias Hartmann
thartmann at openjdk.org
Tue Feb 28 06:59:06 UTC 2023
On Mon, 27 Feb 2023 18:26:51 GMT, Joe Darcy <darcy at openjdk.org> wrote:
>> The wheel of FDLIBM porting turns a notch and sqrt comes into play.
>>
>> While the sqrt operation usually has a hardware implementation that is intrinsified, for completeness a software implementation should be available as well.
>
> Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
>
> - Enable intrinsic for StrictMath.sqrt; thanks to Tobias Hartmann for assistance with the HotSpot updates.
> - Merge branch 'master' into JDK-8302040
> - Implement review feedback.
> - Add one one unsigned shift comment.
> - Respond to review feedback.
> - JDK-8302040: Port fdlibm sqrt to Java
Hotspot changes look good to me.
-------------
Marked as reviewed by thartmann (Reviewer).
PR: https://git.openjdk.org/jdk/pull/12736
More information about the hotspot-compiler-dev
mailing list