RFR: 8299608: Add Register + imm32 orq to x86_64 assembler
Sandhya Viswanathan
sviswanathan at openjdk.org
Wed Jan 4 19:50:51 UTC 2023
On Wed, 4 Jan 2023 15:58:20 GMT, Erik Österlund <eosterlund at openjdk.org> wrote:
> The current x86_64 orq Register + imm32 uses emit_arith, which is rather clever and checks if it can use imm8 instead. However, sometimes you really want it to be imm32 regardless, for example if you are going to patch the code. Such functionality should be added.
>
> Since there seems to be a precedent distinguishing this with testl_imm32(Register, imm32) vs testl(Register, imm32), my proposed patch similarly adds an orq_imm32 that uses emit_arith_imm32.
LGTM
-------------
Marked as reviewed by sviswanathan (Reviewer).
PR: https://git.openjdk.org/jdk/pull/11850
More information about the hotspot-compiler-dev
mailing list