RFR: 8299721: [Vector API] assert in switch-default of LibraryCallKit::arch_supports_vector_rotate is too weak to catch bugs

[Jatin Bhateja]

On Fri, 6 Jan 2023 08:29:02 GMT, Jie Fu <jiefu at openjdk.org> wrote:

> > Rotate operation only works on integral type vectors. But its good to add a fatal msg. Thanks!
> 
> Thanks @jatin-bhateja for your quick review. In real workloads with release VMs, the assert isn't enough to catch the bug since it would just fallback to un-inlined version. Do you think it is trivial?

Yes, I agree fatal is correct alternative, your fix look correct, if you see an assertion failure it will be good to capture it in a test.
Best Regards.

-------------

PR: https://git.openjdk.org/jdk/pull/11877