RFR: 8292443: Weak CAS VarHandle/Unsafe tests should test always-failing cases

[David Holmes]

On Tue, 16 Aug 2022 15:06:50 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> I noticed that current VarHandle/Unsafe test cases do not test the always-failing cases. Strong CASes do test both always-success and always-failing scenarios, while weak CASes only test spurious-failure tests. We should be also testing always-failing cases for these. Weak CAS can spuriously fail, but it cannot spuriously succeed.
> 
> The PR looks large, but the actual changes are in `*.template` files, and the rest is generated from them.
> 
> Additional testing:
>  - [x] Linux x86_64 fastdebug `java/lang/invoke/VarHandles` and `compiler/unsafe` tests
>  - [x]  Linux x86_32 fastdebug `java/lang/invoke/VarHandles` and `compiler/unsafe` tests
>  - [x]  Linux AArch64 fastdebug `java/lang/invoke/VarHandles` and `compiler/unsafe` tests

Committing unchanged files, other than a copyright year change, looks very odd here. Why was the SunMisUnsafe template updated but none of the tests actually changed?

-------------

PR: https://git.openjdk.org/jdk/pull/9892