[jdk20] RFR: 8299733: AArch64: "unexpected literal addressing mode" assertion failure with -XX:+PrintC1Statistics [v2]

[Erik Österlund]

On Mon, 9 Jan 2023 13:58:34 GMT, Nick Gasson <ngasson at openjdk.org> wrote:

> > We ran into a not so fun bug in the ZGC repo, where the lack of initialization of _base and _index led to strange corruption and unintended results. We are carrying a patch locally to always initialize them, that I have been thinking of upstreaming. In the end, it seems like just initializing them is the safest option, rather than keeping track of all the exact places where reading the fields will potentially have corrupt data.
> 
> As far as I can tell it is always initialised in the various `Address` constructors, but since it's a union you have to check `_mode` first to know which interpretation to use.

Hmm, you are right. It looks like the problem we experienced has been fixed.

-------------

PR: https://git.openjdk.org/jdk20/pull/87