RFR: 8299327: Allow super late barrier expansion of store barriers in C2
Erik Österlund
eosterlund at openjdk.org
Tue Jan 10 09:15:58 UTC 2023
On Mon, 9 Jan 2023 15:23:50 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:
>> ZGC uses super late barrier expansion for load barriers in C2. Generational ZGC needs to do the same thing but for store barriers.
>
> src/hotspot/share/opto/graphKit.cpp line 1569:
>
>> 1567: st->as_Store()->set_unsafe_access();
>> 1568: }
>> 1569: if (barrier_data != 0) {
>
> Do we need this check? The analogous load construction logic (https://github.com/openjdk/jdk/blob/17a3f0e2577f2f9eb3fe62a4b8261e3dbe4c3b28/src/hotspot/share/opto/memnode.cpp#L951) does not have it.
I'll remove the check for consistency.
-------------
PR: https://git.openjdk.org/jdk/pull/11779
More information about the hotspot-compiler-dev
mailing list