RFR: 8298632: [TESTBUG] Add IR checks in jtreg vectorization tests [v3]

Pengfei Li pli at openjdk.org
Fri Jan 13 08:22:13 UTC 2023


On Thu, 12 Jan 2023 11:07:54 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>> Pengfei Li has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update copyright years to 2023
>
> test/hotspot/jtreg/compiler/vectorization/runner/ArrayCopyTest.java line 78:
> 
>> 76:     // ---------------- Simple Copy ----------------
>> 77:     @Test
>> 78:     @IR(applyIfCPUFeatureOr = {"asimd", "true", "avx2", "true"},
> 
> For X86 you can replace avx2 with sse for store vector checks.

This is also updated in my last commit. Could you help verify these again?

> test/hotspot/jtreg/compiler/vectorization/runner/ArrayShiftOpTest.java line 77:
> 
>> 75:     public int[] intCombinedRotateShift() {
>> 76:         int[] res = new int[SIZE];
>> 77:         for (int i = 0; i < SIZE; i++) {
> 
> IR checking is currently being done for STORE node where as the test is written for ROTATE operation.  AVX512F has direct rotate instruction support. Same comment applies to other cases, we should be checking for the exact operation nodes.

Thanks for your good suggestion! In my latest commit, IR rules are updated with more exact operations in most of the cases. The ROTATE operation applies for x86 only so I added an additional rule for `avx512f` there.

-------------

PR: https://git.openjdk.org/jdk/pull/11687


More information about the hotspot-compiler-dev mailing list