RFR: JDK-8300069: Left shift of negative value in share/adlc/dict2.cpp [v3]

Justin King jcking at openjdk.org
Fri Jan 13 16:01:58 UTC 2023


On Fri, 13 Jan 2023 15:55:42 GMT, Justin King <jcking at openjdk.org> wrote:

>> Refactor `hashstr` to use unsigned integrals to avoid undefined behavior.
>
> Justin King has refreshed the contents of this pull request, and previous commits have been removed. Incremental views are not available.

Okay, I quickly looked at the C++23 draft standard and couldn't find much regarding negative integral on the left side and left shifting. So let's disable this check, as I agree it's being a bit to pedantic.

Updated the pull request to silence this and reverted the original proposed changes.

-------------

PR: https://git.openjdk.org/jdk/pull/11977


More information about the hotspot-compiler-dev mailing list