Integrated: 8299847: RISC-V: Improve PrintOptoAssembly output of CMoveI/L nodes

Fei Yang fyang at openjdk.org
Tue Jan 17 03:10:18 UTC 2023


On Tue, 10 Jan 2023 09:01:57 GMT, Fei Yang <fyang at openjdk.org> wrote:

> Witnessed some incorrect/strange branch condition code in PrintOptoAssembly output on RISC-V which is quite misleading. While this won't affect release build, we should fix this for debug build. This also fixes the pipeline for those nodes and bumps the BRANCH_COST a little bit as I think control transfer instructions should have higher cost than regular integer computational instructions.
> 
> With this fix, we have some new PrintOptoAssembly output like following snippet:
> 
>    460 202     B41: #  out( B42 ) <- in( B40 )  Freq: 55.6844
>    461 202 +   li R7, #0       # int, #@loadConI
>    462 204 +   addiw  R28, R9, #1      #@addI_reg_imm
>    463 208 +   li R29, #0      # int, #@loadConI
>    464 20a +   CMove R28, (R28 lt R29), R28, R7        #@cmovI_cmpI      <=============
> 
> 
> Testing: Tier1 tested on HiFive Unmatched board.

This pull request has now been integrated.

Changeset: 859ccd1a
Author:    Fei Yang <fyang at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/859ccd1a150653c42ebbcd3402994ef9ff4c810f
Stats:     41 lines in 1 file changed: 1 ins; 12 del; 28 mod

8299847: RISC-V: Improve PrintOptoAssembly output of CMoveI/L nodes

Reviewed-by: fjiang, shade

-------------

PR: https://git.openjdk.org/jdk/pull/11919


More information about the hotspot-compiler-dev mailing list