RFR: 8299074: nmethod marked for deoptimization is not deoptimized [v2]

Tobias Hartmann thartmann at openjdk.org
Tue Jan 17 15:34:49 UTC 2023


On Tue, 17 Jan 2023 15:24:47 GMT, Robbin Ehn <rehn at openjdk.org> wrote:

>> Tobias Hartmann has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Do not check the dependency on already marked nmethods
>
> src/hotspot/share/code/dependencyContext.cpp line 86:
> 
>> 84:         changes.mark_for_deoptimization(nm);
>> 85:         found++;
>> 86:       }
> 
> A minor suggestion is to move the found++ from the individual branches to here, so there is only one.
> Looks good!

But that would increment `found` also in the cases where no method was marked for deoptimization, right?

-------------

PR: https://git.openjdk.org/jdk/pull/12012


More information about the hotspot-compiler-dev mailing list