RFR: 8299570: [JVMCI] Insufficient error handling when CodeBuffer is exhausted [v2]

[Doug Simon]

On Wed, 11 Jan 2023 18:41:19 GMT, Doug Simon <dnsimon at openjdk.org> wrote:

>> src/hotspot/cpu/aarch64/nativeInst_aarch64.cpp line 542:
>> 
>>> 540:       JVMCI_ERROR_0("could not emit trampoline stub - code cache is full");
>>> 541:     }
>>> 542:   }
>> 
>> The if (stub == null) test below should be the else branch of this if which I think makes it clearer. Why do we even bother returning the stub?
>
>>The if (stub == null) test below should be the else branch of this if which I think makes it clearer
> 
> I'm suspecting this is indeed a dormant bug. I will investigate further.
> 
> @theRealAph any chance you recall the intended logic here?

I've pushed https://github.com/openjdk/jdk/pull/11945/commits/0e4fb6501dbff8259c7ae131bf81e03e7e362b94 which attempts to clear up the logic in this method. It would be great if some aarch64 experts could help review it (cc @adinn @theRealAph).

-------------

PR: https://git.openjdk.org/jdk/pull/11945