RFR: 8291801: IGV: Broken button "Hide graphs which are the same as the previous graph" [v2]

Koichi Sakata ksakata at openjdk.org
Thu Jan 19 05:53:32 UTC 2023


On Thu, 29 Sep 2022 09:36:04 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:

>> Koichi Sakata has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision:
>> 
>>  - Set value to hideDuplicates field
>>  - Merge remote-tracking branch 'upstream/master' into JDK-8291801
>>  - Remove extra whitespaces
>>  - Improve the test
>>  - Add the test method
>>  - Remove extra code
>>  - Fix the broken button "Hide graphs which are the same as the previous graph" in IGV
>
> I could also reproduce the issue on Windows 10, using JDK 11.0.16.
> 
> I noticed an interesting pattern (on both Linux and Windows): if I iterate a few times the following sequence, the number of hidden graphs grows monotonically (but non-deterministically), and after a few iterations all graphs expected to be hidden are indeed hidden:
> 1. Open `hello.xml`
> 2. Open any graph of the `virtual void java.lang.Object.<init>()` group
> 3. Click on the "Hide graphs which are the same..." button
> 4. Click on "Remove all graphs and groups" button in the Outline window.

Hi @robcasloz @tobiasholenstein I've fixed the issues discussed above. 
I have tested this feature on the following OSes.
* macOS 13.1
* Windows 11 22H2 (OS build 22621.1105)
* Ubuntu 18.04.6

Graphs are compared when a user pushes the "Hide graphs ..." button, not when they opens a graph file. This task runs just once.

Could you restart the review for this pull request?

-------------

PR: https://git.openjdk.org/jdk/pull/10440


More information about the hotspot-compiler-dev mailing list