RFR: JDK-8289748: C2 compiled code crashes with SIGFPE with -XX:+StressLCM and -XX:+StressGCM [v2]

Tobias Holenstein tholenstein at openjdk.org
Thu Jan 19 08:39:05 UTC 2023


On Wed, 18 Jan 2023 16:26:32 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Tobias Holenstein has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - updated JTreg TestRemoveEmptyCountedLoop
>>  - create SubINode directly with CastIINode as input
>
> src/hotspot/share/opto/loopTransform.cpp line 3696:
> 
>> 3694:   Node* exact_limit = phase->exact_limit(this);
>> 3695: 
>> 3696:   // There might have been a condition guarding the counted loop.
> 
> There should always be a zero trip guard (ensured by code above). So, I would rephrase this to make it more clear that we always need to do the pin on this guard (or remove this phrase completely).

Thx. I rephrased the comment

-------------

PR: https://git.openjdk.org/jdk/pull/11990


More information about the hotspot-compiler-dev mailing list