RFR: 8299975: Limit underflow protection CMoveINode in PhaseIdealLoop::do_unroll must also protect type from underflow [v2]

Emanuel Peter epeter at openjdk.org
Fri Jan 20 10:59:55 UTC 2023


On Fri, 20 Jan 2023 09:45:40 GMT, Roland Westrelin <roland at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   ignore debug flag for product build
>
> src/hotspot/share/opto/loopTransform.cpp line 2338:
> 
>> 2336:         register_new_node(adj_bool, ctrl);
>> 2337:         // Prevent type from becoming too pessimistic due to type underflow. The new limit
>> 2338:         // may be arbitrarily decreased by unrolling, but we know it is in [min_int, hi].
> 
> The comment only applies to stride > 0

Thanks for the suggestion, I packed it into the new refactoring/renaming.

-------------

PR: https://git.openjdk.org/jdk/pull/12092


More information about the hotspot-compiler-dev mailing list