RFR: 8299975: Limit underflow protection CMoveINode in PhaseIdealLoop::do_unroll must also protect type from underflow [v4]

Christian Hagedorn chagedorn at openjdk.org
Fri Jan 20 11:19:34 UTC 2023


On Fri, 20 Jan 2023 11:15:57 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   typo correction
>
> test/hotspot/jtreg/compiler/loopopts/TestCMoveLimitType.java line 31:
> 
>> 29:  *                   -XX:CompileCommand=compileonly,compiler.loopopts.TestCMoveLimitType::test*
>> 30:  *                   -XX:CompileCommand=dontinline,compiler.loopopts.TestCMoveLimitType::dontInline
>> 31:  *                   -XX:RepeatCompilation=50 -XX:+StressIGVN
> 
> You could also remove `RepeatCompilation` here and in the run below. If there is a problem at some point, we would eventually catch it by re-executing the test over and over again in our testing due to having a different seed each time.

Maybe you can also add `@key stress randomness`.

-------------

PR: https://git.openjdk.org/jdk/pull/12092


More information about the hotspot-compiler-dev mailing list