RFR: JDK-8300240: Replace NULL with nullptr in share/ci/

Vladimir Kozlov kvn at openjdk.org
Fri Jan 20 19:39:50 UTC 2023


On Tue, 17 Jan 2023 11:07:10 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

> Do the conversion in the share/ci/ sub-directory and all of its files.

> Regarding the confusion regarding `null` and `nullptr` in comments :). Yes, the idea is that we use `null` in comments as it reads better. In _some_ situations I've chosen to keep `nullptr` in comments, this is specifically when there are code

As owner of the code I prefer to match comments and code.

> This was discussed in a previous review, as you suspected.

Please, point me to that discussion.

-------------

PR: https://git.openjdk.org/jdk/pull/12029


More information about the hotspot-compiler-dev mailing list