RFR: 8300590: [JVMCI] BytecodeFrame.equals is broken [v3]

[Dean Long]

On Fri, 20 Jan 2023 15:23:25 GMT, Doug Simon <dnsimon at openjdk.org> wrote:

>> `BytecodeFrame.equals` returns true even when the frames are found to be not equal: https://github.com/openjdk/jdk/blob/7bf0d1465e73d83aae30f1cd9fd318af9e9c1b70/src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.code/src/jdk/vm/ci/code/BytecodeFrame.java#L375
>> 
>> This PR fixes that, adds a test and improves both `BytecodeFrame.hashCode` and `BytecodeFrame.equals` to take all fields into account.
>> 
>> Given the nature of the bug in `BytecodeFrame.equals` that this PR fixes, it's pretty clear that `BytecodeFrame` has never been (reliably) used as a key in a map.
>
> Doug Simon has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix test failure when assertions are enabled

Looks good.

-------------

Marked as reviewed by dlong (Reviewer).

PR: https://git.openjdk.org/jdk/pull/12084