RFR: 8295486: Inconsistent constant field values observed during compilation [v7]

Tobias Hartmann thartmann at openjdk.org
Thu Jan 26 06:11:39 UTC 2023


On Wed, 25 Jan 2023 19:51:47 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Tobias Hartmann has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Assert to catch duplicates and GrowableArray init
>
> src/hotspot/share/ci/ciObject.hpp line 70:
> 
>> 68:     public:
>> 69:       ConstantValue() : _off(0), _value(ciConstant()) { }
>> 70:       ConstantValue(int off, ciConstant value) : _off(off), _value(value) { }
> 
> Why this order of fields? The `_value` field is 64-bit aligned (for jdouble). You may have space after `_off`

No particular reason. I switched the order of the fields.

-------------

PR: https://git.openjdk.org/jdk/pull/11861


More information about the hotspot-compiler-dev mailing list