RFR: 8301133: IGV: NPE occurs when creating a diff graph with a graph in a different folder
Christian Hagedorn
chagedorn at openjdk.org
Thu Jan 26 15:14:19 UTC 2023
On Thu, 26 Jan 2023 08:31:30 GMT, Koichi Sakata <ksakata at openjdk.org> wrote:
> NullPointerException occurs when we create a diff graph with graphs in different folders. In this case, the graph's group doesn't have a parent. So the `getParent()` call in the Group class returns null.
>
> A diff graph in the same folder show the text "[index] - [folder name]" in the tooltip. In this pull request, a diff graph with graphs in different folders shows the fixed string "Difference" because that string is set to the group name when a diff graph is created.
>
> <img width="700" alt="スクリーンショット 2023-01-26 16 47 57" src="https://user-images.githubusercontent.com/60008/214790051-c236f580-3dcd-4e63-80ee-12a766736185.png">
Looks good.
-------------
Marked as reviewed by chagedorn (Reviewer).
PR: https://git.openjdk.org/jdk/pull/12214
More information about the hotspot-compiler-dev
mailing list